Remove Headers and Modules from SentryCocoaFramework before packing #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4533 +/- ##
==========================================
+ Coverage 73.45% 73.48% +0.02%
==========================================
Files 482 482
Lines 17678 17678
Branches 3493 3493
==========================================
+ Hits 12986 12991 +5
+ Misses 3801 3798 -3
+ Partials 891 889 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jpnurmi
reviewed
Sep 17, 2025
This was referenced Sep 22, 2025
This was referenced Sep 22, 2025
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
jamescrosswell
commented
Oct 6, 2025
| // -(instancetype _Nonnull)initWithType:(NSString * _Nonnull)type length:(NSUInteger)length contentType:(NSString * _Nullable)contentType itemCount:(NSNumber * _Nonnull)itemCount; | ||
| [Export ("initWithType:length:contentType:itemCount:")] | ||
| NativeHandle Constructor (string type, nuint length, string contentType, NSNumber itemCount); | ||
| NativeHandle Constructor (string type, nuint length, [NullAllowed] string contentType, NSNumber itemCount); |
There was a problem hiding this comment.
Why has this changed?
There was a problem hiding this comment.
I suppose we are missing dirty-check for ApiDefinitions.cs. It was changed to nullable in 8.56.1:
This was referenced Oct 6, 2025
This was referenced Oct 6, 2025
jamescrosswell
added a commit
that referenced
this pull request
Oct 6, 2025
Workaround for #4292: - #4292 (comment) Replaces #4533 (targets version6 branch instead of main so that we can get adequate feedback from users before releasing this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #4292:
Warning
We should publish a pre-release from this branch and validate this resolves the problem before merging into main... this is quite a major change.